Change product's price color away from link color #2174
Conversation
notapatch
commented
Aug 22, 2017
•
notapatch
commented
- price on products page has a link color but it is not a link
- links should be distinct to improve usability
- chosen color variable product_body_text_color
notapatch
force-pushed
the
price_is_not_a_link
branch
from
95fa612 to
c4c9678
Compare
|
I am open to suggestions on what color variable you would like the price text to be but since it isn't a link ... this is more an "anything but link color" pull request. The price still remains distinct through size alone. |
|
I'm not picky on colors at all (or the default frontend, for that matter), but @Mandily might have an opinion. |
|
I agree with @notapatch - it is confusing to have the prices looking like links. Swapping the variable for the product_body_text_color looks fine to me. Screenshot for anyone wondering what this looks like: 👍
|
jhawthorn
added
the
changelog:solidus_frontend
|
I didn't explain it very well - I did not mention this was for the products#show page (I will do print screens to help reviewers) and not the products#index page as in the above image. However, as @Mandily points out .. the products#index page is also using the link colors for non-links. If people are agreeable, I can extend the pull request to include the price on the product's index page - I will also check if price appears consistently throughout the front end application before resubmitting. |
|
Sounds good to me @notapatch Can you post screenshots once you've made changes to the other areas please and thanks! |
- product price is the same color as a link but it is not a link
- links should be distinct to improve usability
- chosen color variable $product_price_text_color
notapatch
force-pushed
the
price_is_not_a_link
branch
from
c4c9678 to
919924c
Compare
What do shopping sites do with price colors?I took the first 20 sites from Alexa shopping category [1] and 3/4 of the websites had the non-sale price in black. Four sites used a brand or accent color on #index and the #show page and one site had different price colors on index and show. In other words, if I show the price in black and leave a variable to change the price color then we can mock the requirements for 95% of the websites in the top 20. What did I change?I chose an application unique dark gray color so that anyone picking the color can grep and find it quickly - #252525. What pages were changed?products#index, products#show, orders#edit, checkout order summary panel (affecting Address, Delivery, Payment) and checkout confirm. Products#index Before
Products#index After
Orders#edit Before
Orders#edit After
Checkout order summary panel Before
Checkout order summary panel After
Checkout - confirm Before
Checkout - confirm After
DiscussionFor a few lines of code, this is a big change to the appearance - we might only want the change affecting products#index and products#show for now? Or make the change and update the checkout pages to go with the price color change? [1] - I did not count Amazon.co.uk as I assumed it was the same as Amazon.com, Netflix because they required a login and I assume they aren't going to be a standard shopping site. |
|
Looks good to me! 👍 |
