Fix StoreCredit with multiple currencies #2183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functionality changes.
- StoreCredits can only be used with orders of the same currency. - Summing up amounts of different currencies gives a meaningless number.
This will replace `User#total_available_store_credit`.
This fixes this scenario: - Joe gets $5 USD in store credit - Joe starts an order in JPY - Joe starts checking out and `Spree::Order#add_store_credit_payments` applies Joe's $5 store credit as ¥5 (which is around $0.05 currently) - Joe continues checkout and tries to complete his order but the payment auth/capture fails when Solidus realizes the store credit currency doesn't match the order currency. Joe cannot check out because he has no way to prevent Solidus from trying to apply his store credit.
To fix potential currency problems when a User has store credits that don't match the currency of their current Order.
jordan-brough
force-pushed
the
store-credit-currency-fix
branch
from
4debea7 to
249eb35
Compare
And the corresponding User#display_total_available_store_credit
jordan-brough
force-pushed
the
store-credit-currency-fix
branch
from
249eb35 to
4dfb51f
Compare
We can now have multiples of these.
|
FYI: I force-pushed after Thomas's review to fix some specs and add some specs. No code changes except for the last minor commit. |
cbrunsdon
approved these changes
Aug 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commits.
High level overview:
It took some effort to not attempt a refactor of a bunch of the scary or weird-looking StoreCredit code I noticed while working on this.