Fix backend data-action across multiple files #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need to put unsemantic actions like green or red there. It is better to clearly indicate what that action does, even if it does not reflect any tooltip color change.
We are uncorrectly using fa-void icons on cancel action. This will make cancel icons and tooltips take warning color instead of a wrong error color, when hovering.
js components will not rely anymore on icons implementations. It will use a semantically improved data-actions of links.
It will survive if we change icons framework, also it is more samantically correct.
kennyadsl
force-pushed
the
normalize-data-actions
branch
from
9c026fe to
4a4cc92
Compare
|
Cool that! |
cbrunsdon
approved these changes
Aug 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In backend there are multiple links with inconsistent
data-actionattributes.For example
data-action="red"ordata-action="green", which are both not semantic and do not change tooltip colors when needed (tooltip colors are defined with actions names, not color).With this PR we also start using these semantic
data-actioninto js to target buttons instead of rely on class names that can change in the future, like icons ones (fa-something).The only real effect of this PR on the UI is that buttons and tooltips use the right color now:
Stock Management
Before
After
Stock Transfer
Before
After
Store Credits
Before
After