Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove upgrade task/spec #2192

Merged
merged 1 commit into from
Sep 10, 2017
Merged

Remove upgrade task/spec #2192

merged 1 commit into from
Sep 10, 2017

Conversation

cbrunsdon
Copy link
Contributor

This was for 1.3, I think we're pretty safe to remove now that we're
heading into 2.4.

tvdeyen
tvdeyen approved these changes Aug 30, 2017
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m fine with that as stores already have to upgrade to 2.0 and Rails 5 before upgrading to 2.4

We should add a changelog and/or “How to incrementally upgrade” section into the readme. Or do we have? (Too lazy 😊)

mamhoff
mamhoff approved these changes Aug 30, 2017
View reviewed changes
Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good with me.

Remove upgrade task/spec
bffeaaf 
This was for 1.3, I think we're pretty safe to remove now that we're
heading into 2.4.
@cbrunsdon cbrunsdon merged commit 5cd7058 into solidusio:master Sep 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamhoff mamhoff mamhoff approved these changes

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbrunsdon @tvdeyen @mamhoff