Remove task to copy shipped shipments to cartons #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrunsdon
force-pushed
the
remove_copy_to_carton_task
branch
from
390cd8c to
53cb00a
Compare
kennyadsl
approved these changes
Aug 30, 2017
This was supposed to be ran back in the 1.2 days, and we don't need to keep it around anymore. It'll still be in the repo history if anyone needs it for whatever reason. This also removes the migration, as anyone that has ran migrations on any store in the last 6 versions will have it, and it stops migrations in test_app's from running.
cbrunsdon
force-pushed
the
remove_copy_to_carton_task
branch
from
53cb00a to
6138b9e
Compare
|
@askl56 Agreed, just wanted to chime in and share this was a breaking change on my end as well. I believe general best practices are to keep the migration history intact, no? I too love to delete code, but if it were me, I think I would've kept the migration as is and left the rake task blank. |
|
Fair point, we'll take that into account for the next releases. FYI, I think we already started deprecating rake tasks before removal (that only happens in major releases). Thanks for letting us know about the trouble! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was supposed to be ran back in the 1.2 days, and we don't need to
keep it around anymore. It'll still be in the repo history if anyone
needs it for whatever reason.