Remove PriceMigrator #2194
Merged
Remove PriceMigrator #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrunsdon
force-pushed
the
remove_price_migrator
branch
2 times, most recently
from
4795834 to
f7b0963
Compare
|
Can I PR more removals to this PR? If we get rid of this migration, I would also like to remove Spree::Zone.default_tax and all the code paths that do the weirdo "tax refund" thing. |
mamhoff
approved these changes
Aug 30, 2017
|
I'll PR that other removal separately. |
Merged
cbrunsdon
force-pushed
the
remove_price_migrator
branch
2 times, most recently
from
19e5ade to
cac7689
Compare
This was intended to be run in the 1.3 build, and should be safe to remove now as we head into 2.4. The task will still be there for anyone that wants it, but its more likely that if they're moving to 2.4 this isn't going to do them any good.
cbrunsdon
force-pushed
the
remove_price_migrator
branch
from
cac7689 to
a02294f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was intended to be run in the 1.3 build, and should be safe to
remove now as we head into 2.4.
The task will still be there for anyone that wants it, but its more
likely that if they're moving to 2.4 this isn't going to do them any
good.