Replace Stock::Coordinator with Stock::SimpleCoordinator #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
force-pushed
the
simple_stock_coordinator
branch
from
768a5d8 to
12deb68
Compare
jhawthorn
force-pushed
the
simple_stock_coordinator
branch
from
a37c32c to
ec7b241
Compare
jhawthorn
force-pushed
the
simple_stock_coordinator
branch
from
ec7b241 to
d0f3bd4
Compare
jhawthorn
changed the title
jhawthorn
force-pushed
the
simple_stock_coordinator
branch
from
d0f3bd4 to
0f0a97c
Compare
mamhoff
approved these changes
Sep 8, 2017
| end | ||
| end | ||
|
|
||
| # Subtracks another StockQuantities from this one |
This spec previously created two line_items, and relied on the order they came back from the DB (and only testing the first). I believe the second line item was not intended by the original author of this spec. This commit removes the second line item and makes the spec consistent regardless of DB ordering.
This commit introduces StockQuantities, a value class representing counts for a number of variants. This class provides set-like operations to make to make it easier to deal with and reason about stock.
This commit adds Spree::Stock::Availability, a class to manage checking stock availability efficiently for a set of Variants and StockLocations. This is similar to the existing Spree::Stock::Quantifier, but more efficient by checking multiple variants at once. This needs only two queries to check stock for any number of variants and stock_locations (though passing fewer will have faster queries). This would be a good candidate to be a pluggable class. It could in theory be overridden to provide oft-requested features like stock reservations and querying other sources (like 3PL or ERP). I haven't done this at this time because the interface isn't the best suited to be generic and instead is just the most convenient for the one place its used now. To do this the class would also have to include unstocking and restocking.
This class is intended to replace Spree::Stock::Coordinator as well as its helper classes: Stock::Adjuster Stock::Packer Stock::Prioritizer This solves several issues and bugs with the existing Coordinator, where stock coordination would fail despite actually having enough stock. It should also be faster than the existing Coordinator by making use of the new Stock::Availability class. My hope is that this class is simple enough that it could be copied in to stores and used as a starting point to customizations.
This commit removes * Spree::Stock::Coordinator * Spree::Stock::Packer * Spree::Stock::Prioritizer * Spree::Stock::Adjuster as well as specs and factories
These specs failed with the old Stock::Coordinator
jhawthorn
force-pushed
the
simple_stock_coordinator
branch
from
0f0a97c to
332e216
Compare
|
@swcraig is working on the |
benjaminwil
added a commit
to benjaminwil/solidus
that referenced
this pull request
Nov 1, 2017
The way split shipments works has changed significantly in Solidus v2.4.0. See solidusio#2199 for more information.
benjaminwil
added a commit
to benjaminwil/solidus
that referenced
this pull request
Nov 24, 2017
This article revises the documentation for split shipment management in Solidus, which changed as of Solidus v2.4.0. See solidusio#2199 for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
Spree::Stock::SimpleCoordinator, which is intended to fix the issues with and replace:Spree::Stock::CoordinatorSpree::Stock::AdjusterSpree::Stock::PackerSpree::Stock::PrioritizerThis solves several issues and bugs with the existing Coordinator, where stock coordination would fail despite actually having enough stock. It should also be faster than the existing Coordinator by making use of the new Stock::Availability class.
This fixes #583 and #2122
It is also intended to contain all the business logic for how stock is packaged in the
SimpleCoordinatorclass itself (vs split across Packer/Adjuster/Prioritizer). This should make it a better starting point for stores which want to implement their own coordinator class.Spree::StockQuantitiesThis introduces
StockQuantities, a value class representing counts for a number of variants.This class provides set-like operations to make to make it easier to deal with and reason about stock.
Stock::AvailabilityThis commit adds Spree::Stock::Availability, a class to manage checking stock availability efficiently for a set of Variants and StockLocations.
This is similar to the existing Spree::Stock::Quantifier, but more efficient by checking multiple variants at once. This needs only two queries to check stock for any number of variants and stock_locations
(though passing fewer will have faster queries).
This would be a good candidate to be a pluggable class. It could in theory be overridden to provide oft-requested features like stock reservations and querying other sources (like 3PL or ERP). I haven't done this at this time because the interface isn't the best suited to be generic and instead is just the most convenient for the one place its used now. To do this the class would also have to include
unstocking and restocking.