Deprecate .calculators #2216
Merged
Deprecate .calculators #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes sense. Going through the Config opposed to the class further separates the usage from the implementation. +1 |
cbrunsdon
force-pushed
the
deprecate_calculator_dot_calculators
branch
4 times, most recently
from
3aac9c7 to
8edd3df
Compare
There are almost no reasonable reasons why these should be called through the class models the way they are, near as I can tell they're only ever used for display/form purposes in the backend.
cbrunsdon
force-pushed
the
deprecate_calculator_dot_calculators
branch
from
8edd3df to
8dfedd2
Compare
mamhoff
approved these changes
Sep 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are almost no reasonable reasons why these should be called
through the class models the way they are, near as I can tell they're
only ever used for display/form purposes in the backend.