New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix class definition of variant #2248

Merged

tvdeyen merged 1 commit into solidusio:master from cbrunsdon:variant_base_class

Oct 4, 2017

Contributor

cbrunsdon commented Oct 4, 2017

We shouldn't have multiple inconsistent definitions of the same class.


          Fix class definition of variant

3876f1c

We shouldn't have multiple inconsistent definitions of the same class.

tvdeyen approved these changes

View reviewed changes

mamhoff approved these changes

View reviewed changes

kennyadsl approved these changes

View reviewed changes

tvdeyen merged commit f82de11 into solidusio:master

Member

tvdeyen commented Oct 4, 2017

Short term merge, as there is no breaking behaviour. Quite contrary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet