Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix preference_field_tag when given no type #2278

Merged
merged 1 commit into from
Oct 11, 2017
Merged

Fix preference_field_tag when given no type #2278

merged 1 commit into from
Oct 11, 2017

Conversation

jhawthorn
Copy link
Contributor

@jhawthorn jhawthorn commented Oct 10, 2017 •
edited
Loading

Previous to being deprecated, this defaulted to :text if no type was given. This PR restores that behaviour.

@jhawthorn
Copy link
Contributor Author

Found in solidus_editor

tvdeyen
tvdeyen approved these changes Oct 10, 2017
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jhawthorn jhawthorn added this to the 2.4.0 milestone Oct 11, 2017
@jhawthorn jhawthorn merged commit 43f3d56 into solidusio:master Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jhawthorn @tvdeyen