refactor length == 0 to use empty? method #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmacdougall
approved these changes
Oct 13, 2017
cbrunsdon
approved these changes
Oct 25, 2017
|
@brchristian would you mind to rebase this branch and resolve the conflicts? |
brchristian
force-pushed
the
refactor_length_zero
branch
from
b01205c to
9d99e3d
Compare
|
@tvdeyen Rebased! 👍 |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors two lines in the frontend views that were using
.length == 0. I think that.empty?(or.blank?, or alternately reversing the conditional branches and using.present?) is significantly cleaner!