-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate reception states and fix translation key #2283
Translate reception states and fix translation key #2283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Could you also change the translation itself?
5d2dee6
to
c5edbc9
Compare
Done! |
Just as a note, we use the (generally) American spelling of |
The problem is that the state is called |
c5edbc9
to
43362c0
Compare
Reverted the translation change. |
45a7682
to
871ace7
Compare
@tvdeyen Rebased on master and changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
871ace7
to
aaa2897
Compare
aaa2897
to
5e8664f
Compare
@tvdeyen rebased on master. More than three months have passed, is something blocking this small PR from being merged? |
@rbngzlv we need a second approval. From @kennyadsl maybe? Sorry, that this took so long and thanks for reminding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking too long to approve
@kennyadsl and @tvdeyen I'm doing a friendly reminder about this PR. |
This just needed someone to press the button, sorry again for taking so long to merge! |
Screen capture:
And the translation key for
Canceled
state is with doublel
: https://github.com/solidusio/solidus/blob/master/core/app/models/spree/return_item.rb#L83