Allow access to Spree::Core::Environment through Spree::Config #2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 16, 2017
core/lib/spree/app_configuration.rb
Outdated
| Spree::Promotion::Rules::UserRole | ||
| ] | ||
|
|
||
| promos.actions = %w[ |
There was a problem hiding this comment.
Operator = should be surrounded by a single space.
Unnecessary spacing detected.
houndci-bot
reviewed
Oct 16, 2017
core/lib/spree/app_configuration.rb
Outdated
| Spree::Promotion::Rules::UserRole | ||
| ] | ||
|
|
||
| promos.actions = %w[ |
There was a problem hiding this comment.
Operator = should be surrounded by a single space.
Unnecessary spacing detected.
cbrunsdon
force-pushed
the
environment_through_config
branch
from
875c649 to
82868b8
Compare
added 2 commits
October 16, 2017 03:35
Currently, we have two major way of configuring solidus. The first is the reasonably-clear Spree::Config, which is an instance of Spree::AppConfiguration and contains a number of configuration settings. Secondly is the Spree::Core::Environment, which until this commit was only stored and could only be accessed through Rails.application.config.spree, though there was no clear distinction on why some settings were here and others in Spree::Config. This takes a step forward to clarify those settings, allowing access to the Spree::Core::Environment settings through `Spree::Config.environment`
Setting these "default" values during rails initializers is confusing, as understanding and/or debugging rails initializers is difficult and time consuming. By pushing the setup into the Spree::Config, we can simplify the setup of the environment and remove the confusion around when and in what order these fire. The old initializers are left so existing applications and extensions can hook into them, though they should not notice a difference.
cbrunsdon
force-pushed
the
environment_through_config
branch
from
82868b8 to
e9001a1
Compare
added 2 commits
October 16, 2017 05:20
This is clearer and more direct than going through the rails environment, as we're setting and retrieving settings we directly control.
The Spree::Config object is an instance of AppConfiguration, and clearer than going through the rails environment to test.
cbrunsdon
force-pushed
the
environment_through_config
branch
from
e9001a1 to
21ca4bd
Compare
tvdeyen
approved these changes
Oct 16, 2017
mamhoff
approved these changes
Nov 1, 2017
Could you link this? Definitely been using Rails/Solidus for a while still get confused by the initialization process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the Spree::Core::Environment (previously only accessible through Rails.application.config.spree) available via the Spree::Config.
This makes configuring Solidus easier in a few ways:
I've left the initializers in in case applications or gems are still using them, and they should be able to continue using them as before, but I think we should think about deprecating them in the future.