Replace Spree.t with plain I18n.t #2309

jhawthorn · 2017-10-19T22:09:31Z

The Spree.t method provides debatable benefit over the standard I18n.t method and t helper.

Spree.t(:foo) is one character shorter than t('spree.foo')
Spree.t('foo.bar') is the same length as t('spree.foo.bar')
Spree.t doesn't support the t(".relative") shorthand (so we currently use both t and Spree.t)
Spree.t generates <span class="translation_missing" on errors (like the t helper), which is surprising because it looks more like I18n.t (which doesn't emit html)
Use of Spree.t prevents us from using tools like i18n-tasks

This PR replaces Spree.t with I18n.t throughout the project.

cbrunsdon · 2017-10-19T22:56:01Z

👍

mamhoff

Yeah, good work.

tvdeyen

Reasonable change. Most of the commits can be stashed into one I guess.

I see the benefit of this and am for doing this, but this forces us to take a extra look while reviewing PRs that introduces translation keys. I am fine with that, though

This existed prior to us making all translations available to JS. We can instead handle this where the datepicker is initialized. This adds support for a "default" option to be passed to Spree.t

jhawthorn added the WIP label Oct 19, 2017

mamhoff approved these changes Oct 20, 2017

View reviewed changes

tvdeyen approved these changes Oct 20, 2017

View reviewed changes

jhawthorn force-pushed the replace_spree_t_with_i18n branch 2 times, most recently from feed9dc to ea28e8d Compare October 20, 2017 22:47

solidusio deleted a comment from houndci-bot Oct 20, 2017

jhawthorn changed the title ~~[RFC] Replace Spree.t with plain I18n.t~~ Replace Spree.t with plain I18n.t Oct 21, 2017

jhawthorn and others added 17 commits October 26, 2017 11:50

Remove JS translation item_stock_placeholder

99490cd

Remove duplicate JS action translations

de73c40

Remove unnecessary data-original-title

384f648

Extract date_picker logic from js_locale_data

def3544

This existed prior to us making all translations available to JS. We can instead handle this where the datepicker is initialized. This adds support for a "default" option to be passed to Spree.t

Replace Spree.t in admin views

c0b82d0

Replace Spree.t in admin helpers

0b48958

Replace Spree.t in backend specs

63afa05

Replace Spree.t in admin controllers

2e9a2ba

Replace Spree.t in api

c7636ab

Replace Spree.t in frontend views

5ed208e

Replace Spree.t in frontend controllers

5e516f3

Replace Spree.t in frontend specs

2dc7602

Replace Spree.t in core models and specs

9f36c55

Replace Spree.t in spree core views

ff316e4

Replace Spree.t in core helpers

b5eac18

Replace Spree.t in core mailers

379b245

Appease rubocop in base_helper

30b4eba

jhawthorn force-pushed the replace_spree_t_with_i18n branch from d8671f2 to 30b4eba Compare October 26, 2017 18:51

jhawthorn merged commit 63b8a55 into solidusio:master Oct 26, 2017

BenMorganIO mentioned this pull request Jun 14, 2018

Deprecate Spree.t #2773

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace Spree.t with plain I18n.t #2309

Replace Spree.t with plain I18n.t #2309

jhawthorn commented Oct 19, 2017 •

edited

Loading

cbrunsdon commented Oct 19, 2017

mamhoff left a comment

tvdeyen left a comment

Replace Spree.t with plain I18n.t #2309

Replace Spree.t with plain I18n.t #2309

Conversation

jhawthorn commented Oct 19, 2017 • edited Loading

cbrunsdon commented Oct 19, 2017

mamhoff left a comment

Choose a reason for hiding this comment

tvdeyen left a comment

Choose a reason for hiding this comment

jhawthorn commented Oct 19, 2017 •

edited

Loading