Remove ffaker #2339
Merged
Remove ffaker #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 31, 2017
| @@ -15,7 +15,7 @@ | |||
| address1 '10 Lovely Street' | |||
| address2 'Northwest' | |||
| city 'Herndon' | |||
| zipcode { FFaker::AddressUS.zip_code } | |||
| sequence(:zipcode, 10001) { |i| i.to_s } | |||
There was a problem hiding this comment.
Use underscores(_) as decimal mark and separate every 3 digits with them.
There was a problem hiding this comment.
no 😠
I have disabled this rule.
| @@ -4,6 +4,6 @@ | |||
| FactoryBot.define do | |||
| factory :promotion_code, class: 'Spree::PromotionCode' do | |||
| promotion | |||
| value { generate(:random_code) } | |||
| sequence(:value) {|i| "code#{i}" } | |||
cbrunsdon
approved these changes
Oct 31, 2017
FFaker is required where it is used.
jhawthorn
force-pushed
the
remove_more_ffaker
branch
from
6108ace to
10b8830
Compare
Previously here we used TwitterCldr to generate zip codes, which we replaced with FFaker. Neither of these generated accurate zipcodes for the state they were in. We might as well just generate codes from 10001 onwards (which should mostly be valid codes in Manhattan).
jhawthorn
force-pushed
the
remove_more_ffaker
branch
from
10b8830 to
83d5ffd
Compare
mamhoff
approved these changes
Nov 1, 2017
kennyadsl
added a commit
to solidusio-contrib/solidus_reviews
that referenced
this pull request
Nov 3, 2017
They are no more present since solidusio/solidus#2339 Also, it follows the direction of the above PR and remove unnecessary fields from some facotry to create minimal objects.
jontarg
added a commit
to jontarg/solidus_support
that referenced
this pull request
Nov 29, 2018
Following solidusio/solidus#2339
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are no longer using ffaker for sample data as of #2163. So we might as well remove the dependency entirely.
The main advantage of ffaker is being able to create data that looks to a human to be somewhat real. This isn't necessary or even desirable for the factories used by our specs, which just need different data. FactoryBot's
sequences are totally adequate for these purposes.This also removes a few "description" fields from factories of models where they were optional (factories should be creating minimal objects).