Remove testing_support/i18n #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
force-pushed
the
remove_testing_support_i18n
branch
from
e559911 to
2b56d51
Compare
tvdeyen
approved these changes
Nov 1, 2017
kennyadsl
approved these changes
Nov 1, 2017
There was a problem hiding this comment.
👍 I didn't even know about this file. Just for reference, if someone needs i18n checks there are external tools, like i18n-tasks gem, which are probably better for this kind of tasks.
mamhoff
approved these changes
Nov 1, 2017
This is a file which was used to detect missing or unused translations, but it is no longer useful. It only detects translations made using Spree.t, which we no longer use, and haven't used exclusively in years. I don't believe the detection of unused translations has ever worked, and the detection of missing translations can use raise_on_missing_translations instead.
jhawthorn
force-pushed
the
remove_testing_support_i18n
branch
from
2b56d51 to
5a2dac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a file which was used to detect missing or unused translations, but it is no longer useful.
It only detects translations made using
Spree.t, which we no longer use, and haven't used exclusively in years. I don't believe the detection of unused translations has ever worked, and the detection of missing translations can useraise_on_missing_translationsinstead.