Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a reference to solidus_cmd in README #2349

Merged
merged 1 commit into from
Nov 9, 2017

Conversation

afdev82
Copy link
Contributor

@afdev82 afdev82 commented Nov 2, 2017

Add a reference to solidus_cmd in README.
I will add more details about how to write extensions in the README of that gem.

@afdev82
Copy link
Contributor Author

afdev82 commented Nov 3, 2017

Added more details with solidusio-contrib/solidus_cmd#14

@mtomov
Copy link
Contributor

mtomov commented Nov 3, 2017

That's just great! Thanks!

Copy link
Contributor

@jhawthorn jhawthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Thanks.

@@ -248,6 +248,8 @@ features to your store that are not (or not yet) part of the core project.

A list can be found at [extensions.solidus.io](http://extensions.solidus.io/).

If you want to write an extension for Solidus, you can use the [solidus\_cmd](https://www.github.com/solidusio/solidus_cmd.git) gem.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the link text. Should be solidus_cmd, without the backslash.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good with me as well, the backslash is fine.

@jhawthorn jhawthorn merged commit 36f499a into solidusio:master Nov 9, 2017
@jhawthorn jhawthorn added the changelog:solidus_core Changes to the solidus_core gem label Nov 9, 2017
@afdev82 afdev82 deleted the add_solidus_cmd_reference branch November 10, 2017 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants