Improve selected_shipping_rate_id= #2355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code worked fine, but it was odd to perform an update to de-select the rate and then re-select the same one when it was unnecessary.
If this fails for any reason, both should be rolled-back
mamhoff
approved these changes
Nov 6, 2017
cbrunsdon
approved these changes
Nov 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some somewhat minor changes to
Shipment#selected_shipping_rate_id=selected_shipping_rate_id=was passed a bad id, the shipment would have no shipping rate selected. (It will now keep the previous selection)update!instead ofupdate, so that exceptions are raised on any errorssave!, all modifications are made on other records.