use single quote to fix deface override, see #2360

[afdev82]

This change seems to fix the #2360 (and so the solidusio-contrib/solidus_editor#12)

[jhawthorn]

I'd prefer this was fixed in deface. There's nothing wrong with our ERB here, deface just doesn't parse it correctly.

It seems like these regexes https://github.com/DefaceCommunity/deface/blob/master/lib/deface/parser.rb#L14-L16
are incorrect

They might need to be

/([\w-]+)(\s?=\s?)(")(([^"]*<%.*?%>)+[^"]*)/m,
/([\w-]+)(\s?=\s?)(')(([^']*<%.*?%>)+[^']*)'/m,
/([\w-]+)(\s?=\s?)()(<%.*?%>)(?:\s|>|\z)/m

[tvdeyen]

Thanks. I am pro this change even without Deface being the source of failure. The mixed quotes in the html vs. Erb are confusing and will probably trip up syntax highlighting as well

[mamhoff]

Oh I had no idea how terrible Deface is. Still, pro this for the reasons @tvdeyen points out.