Avoid loading models when requiring factories #2369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was checking Spree.user_class as soon as it was required, which might not yet have the correct user_class. It also had a bunch of behaviour intended for some (lost to time) custom auth implementation. Any such customizations should be done in the app or extension instead.
Not a huge deal, but we should avoid loading the targets of these factories until they are explcitly run.
jhawthorn
force-pushed
the
avoid_models_on_factory_load
branch
from
cef6a1f to
a418587
Compare
mamhoff
approved these changes
Nov 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes some minor changes to the adjustment, customer_return, stock, and store_credit_type factories so that they don't need their models autoloaded in order to be used.
It also makes some more substatial changes to the user model for the same purpose.