Move role configuration into Spree::Config #2374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the ClassConstantizer::Set when storing the mapping of role names to permission sets. In development, this allows those classes to be reloaded if changes are made to a role defined inside the application.
Previously, RoleConfiguration was a singleton class, which was configured by engine initialization. Instead, we can configure it like the rest of our configuration by moving it to AppConfiguration (and therefore Spree:Config). It is also no longer a Singleton class, which makes testing it simpler. This deprecates RoleConfiguration.instance and RoleConfiguration.configure and has them use Spree::Config.roles instead.
jhawthorn
changed the title
cbrunsdon
approved these changes
Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
RoleConfigurationwas a singleton class, which was configured by engine initialization.Instead, we can configure it like the rest of our configuration by moving it to
AppConfiguration(and thereforeSpree:Config). It is also no longer a Singleton class, which makes testing it simpler.This deprecates
RoleConfiguration.instanceandRoleConfiguration.configureand has them useSpree::Config.rolesinstead