Convert product, variant, stock item, prices to discard #2396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swcraig
reviewed
Nov 23, 2017
core/app/models/spree/product.rb
Outdated
| def paranoia_destroy | ||
| Spree::Deprecation.warn <<-WARN.strip_heredoc | ||
| Calling #destroy (or #paranoia_destroy) on a Product currently performs a soft-destroy using the paranoia gem. | ||
| In Solidus 3.0, paranoia will be removed, and this will perform a HARD destoy instead. To continue soft-deleting, use #discard instead. |
There was a problem hiding this comment.
"...perform a HARD destoy". All three of the deprecation warnings have this.
There was a problem hiding this comment.
This also prompted me to move these warnings to a common ParanoiaDeprecations module.
jhawthorn
force-pushed
the
discard_products
branch
from
b0202c6 to
94f675d
Compare
jhawthorn
changed the title
jhawthorn
changed the title
jhawthorn
force-pushed
the
discard_products
branch
from
94f675d to
aa41298
Compare
kennyadsl
reviewed
Nov 24, 2017
|
|
||
| it "should keep its price if deleted" do | ||
| expect(variant.display_price).to eq(previous_variant_price) | ||
| variant.destroy |
There was a problem hiding this comment.
shouldn't be variant.discard?
jhawthorn
force-pushed
the
discard_products
branch
2 times, most recently
from
0796699 to
cc59d0e
Compare
gmacdougall
approved these changes
Dec 20, 2017
jhawthorn
force-pushed
the
discard_products
branch
from
cc59d0e to
2b1890a
Compare
This deprecates the #paranoia_destroy (and therefore also #destroy) method on these models in favour of using #discard. after_discard callbacks have been added to these models to duplicate the current behaviour of calling #destroy (before_destroy callbacks and destroying of dependent: :destroy associations).
jhawthorn
force-pushed
the
discard_products
branch
from
2b1890a to
b6e8236
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates the
#paranoia_destroy(and therefore also#destroy) method on these models in favour of using #discard.after_discardcallbacks have been added to these models to duplicate the exact current behaviour of calling#destroy(before_destroycallbacks and destroying ofdependent: :destroyassociations). In the future we probably want to change this behaviour (why do we delete images when soft-deleting variants?), but that isn't being done here.