Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select2 above styles #2412

Merged
merged 1 commit into from
Dec 20, 2017

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Nov 29, 2017

Extracted from #2255

In some rare circumstances the select2 dropdown opens above not below. As select2 is overly specific with this styles we need to overwrite these with our theme as well.

This also fixes some border-radius issues we had.

Before

localhost_3000_admin_orders_r123456789_cart 1

After

localhost_3000_admin_orders_r123456789_cart

In some rare circumstances the select2 dropdown opens above not below. As select2 is overly specific with this styles we need to overwrite these with our theme as well.

This also fixes some border-radius issue we had.
@tvdeyen tvdeyen added changelog:solidus_backend Changes to the solidus_backend gem Code review needed labels Nov 29, 2017
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@jhawthorn jhawthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@jhawthorn jhawthorn merged commit ba8307b into solidusio:master Dec 20, 2017
@tvdeyen tvdeyen deleted the fix-select2-above-styles branch February 14, 2019 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants