Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin order shipments ui cleaning #2414

Merged
merged 4 commits into from
Dec 12, 2017

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Nov 29, 2017

Extracted from #2255

Includes 1fa77b3 from #2411

Before

shipments add item before

After

shipments - add item after

order shipments after

We sometimes want to vertically align table rows to the middle, not to the top as we do by default now.

This new class allows to do so.
These rows have input fields if editable and therefore look much better if vertically aligned to the middle instead of our default (top aligned)
@tvdeyen tvdeyen added changelog:solidus_backend Changes to the solidus_backend gem Code review needed labels Nov 29, 2017
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

@jhawthorn jhawthorn merged commit cad4167 into solidusio:master Dec 12, 2017
@tvdeyen tvdeyen deleted the admin-order-shipments-ui-cleaning branch February 8, 2019 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants