Store credit admin UI fixes #2426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
added
changelog:solidus_backend
tvdeyen
force-pushed
the
store-credit-admin-fixes
branch
from
81ba8de to
449e582
Compare
kennyadsl
reviewed
Dec 6, 2017
core/config/locales/en.yml
Outdated
| category_id: Credit Type | ||
| amount_authorized: Authorized | ||
| amount_credited: Credited | ||
| amount_used: Used |
There was a problem hiding this comment.
I'm not sure these 3 keys are ok, since it could not be clear that they refer to the amount.
Eg.
Used cannot be greater than the credited amount
I don't get what we gain removing the term Amount
There was a problem hiding this comment.
You are right. I will change that
houndci-bot
reviewed
Dec 12, 2017
build-ci.rb
Outdated
| # @return [Boolean] | ||
| # the success of the installation | ||
| def self.bundle_install | ||
| system(*%W[ |
There was a problem hiding this comment.
Pass array contents as separate arguments.
build-ci.rb
Outdated
| # | ||
| # @return [Boolean] | ||
| def self.bundle_check | ||
| system(*%W[bundle check --path=#{VENDOR_BUNDLE}]) |
There was a problem hiding this comment.
Pass array contents as separate arguments.
tvdeyen
force-pushed
the
store-credit-admin-fixes
branch
from
ceda8a0 to
65c9f4c
Compare
The current balance already indicates the currency of the store credit tables belonging to a currency group.
Currently it is a untranslated boolean
We have too many borders in our layout. Whitespace, tables and headers are separating content areas already, no need additional borders. That only distracts the eye. Keeps the bottom border for fieldsets that are holding a form. This makes sense as the form buttons sit on top of the bottom border and visually encloses the form field set.
tvdeyen
force-pushed
the
store-credit-admin-fixes
branch
from
65c9f4c to
5d4b8e5
Compare
|
@kennyadsl made the requested changes. Found old unused translation keys and used them for the table headers. |
jhawthorn
approved these changes
Dec 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #2419
Before
After