Remove delimiter on number with currency field #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luukveenis
suggested changes
Dec 11, 2017
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| <div class="input-group number-with-currency <%= "number-with-currency-with-select" unless currency %> js-number-with-currency"> | |||
| <div class="input-group-addon number-with-currency-symbol"></div> | |||
| <%= f.text_field amount_attr, value: number_to_currency(f.object.public_send(amount_attr), unit: ''), class: 'form-control number-with-currency-amount', required: required %> | |||
| <%= f.text_field amount_attr, value: number_to_currency(f.object.public_send(amount_attr), unit: '', delimiter: ''), class: 'form-control number-with-currency-amount', required: required %> | |||
There was a problem hiding this comment.
This can probably be a number_field as well. It's only used in admin forms for numeric values.
|
@luukveenis fixed! |
|
That was a nice idea @luukveenis, but we can't use a |
lgiacalone3
force-pushed
the
remove-admin-currency-delimiter
branch
from
9b7168e to
c7ec843
Compare
|
@jhawthorn @luukveenis Just removed that last commit that replaced the text_field with a number_field. |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a weird bug when editing a promotion - after updating the promotion, the item total dropped from 1000 down to 1. Looks like the delimiter is causing the amount to get truncated when values are 1000 and over.
Probably due to this:
This removes the delimiter from the
number_with_currencypartial, which is used on the promotion edit page. If there are any other fields that should get a similar treatment, feel free to let me know - happy to make the change.