Simplify instructions in README.md for testing all projects #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's merge #2442 first, then I will rebase this |
|
We should probably merge #2447 first as well, so that |
tvdeyen
reviewed
Dec 13, 2017
README.md
Outdated
| test suites. | ||
| A recent version of chrome and chromedriver is required to run the frontend and | ||
| backend test suites. If you don't have chromedriver, | ||
| [`gem install chromedriver-helper`](https://github.com/flavorjones/chromedriver-helper) |
There was a problem hiding this comment.
Using the gem actually conflicts with having it globally installed. I would to see us promoting installing it system wide via package managers instead of via Ruby gems
rake is now all that is needed to run all the tests. Also now explains that chrome, not phantomjs, is required for backend and frontend.
jhawthorn
force-pushed
the
readme_top_level_test
branch
from
843607f to
0147576
Compare
gmacdougall
approved these changes
Dec 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rake is now all that is needed to run all the tests. Also now explains that chrome, not phantomjs, is required for backend and frontend.