New preference to control available currencies #2461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softr8
force-pushed
the
available-currencies
branch
from
01b8bc7 to
6a9178e
Compare
jhawthorn
approved these changes
Dec 18, 2017
core/lib/spree/app_configuration.rb
Outdated
| # | ||
| # @!attribute [r] available_currencies | ||
| # @returns [Array] An array of available currencies from Money::Currency.all | ||
| preference :available_currencies, :array, default: ::Money::Currency.all |
There was a problem hiding this comment.
Only concern is that this should maybe be a proc. We load preferences quite early and customizations might be made to ::Money. (this is really quite an edge case, so I don't know if it's necessary, but can't hurt)
|
This seems to be failing because |
softr8
force-pushed
the
available-currencies
branch
from
6a9178e to
d8fbf86
Compare
softr8
force-pushed
the
available-currencies
branch
from
d8fbf86 to
0caf2b8
Compare
jhawthorn
approved these changes
Dec 18, 2017
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows stores to control what currencies will be available, it could improve usability a bit in some dropdowns by limiting the number of options.