Make credit card parameter filtering more specific #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid unintentionally filtering out other parameters matching these names. In particular "number" is a param that shows up in other places is often important to *have* in the logs. These days most shops don't have credit card numbers posted directly to their applications anyway.
jhawthorn
approved these changes
Jan 18, 2018
There was a problem hiding this comment.
Looks good to me.
I double checked this by looking through the logs after a spec run and as far as I can tell it filtered all occurrences of "number" it should have.
I used:
cat backend/spec/dummy/log/test.log | grep '^ Parameters:' | grep number
cat frontend/spec/dummy/log/test.log | grep '^ Parameters:' | grep number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid unintentionally filtering out other parameters matching these names. In
particular "number" is a param that shows up in other places is often important
to have in the logs.
These days most shops don't have credit card numbers posted directly to their
applications anyway.
Relevant previous PR: #1755 and issue: #1752