Tweaks to override-solidus-assets.md #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmacdougall
approved these changes
Jan 11, 2018
tvdeyen
reviewed
Jan 11, 2018
| @@ -24,7 +24,8 @@ might not be effective for the next. | |||
|
|
|||
| If you want to tweak a CSS definition or change the way a particular JavaScript | |||
| methods works, you can override it by redefining the definition in a file in | |||
| your application's `app/assets` tree. | |||
| your application's `app/assets` tree, although this isn't guaranteed to work in | |||
| future versions of Solidus. | |||
There was a problem hiding this comment.
As far as I read this paragraph it handles overriding a single CSS rule or JS function in a separate file, not overwriting the defining file itself. This is handled below. And overwriting things like this is always supported, no? Or am I misreading something?
There was a problem hiding this comment.
You're right. I was confused about what this was describing. We should probably change this section (in a future PR) because "redefining" isn't an accurate description of what happens when adding additional CSS (and is likely misleading for JS too).
At some point in the future it's possible we will use an asset bundler other than sprockets (like webpack or rollup). If we do so we won't be able to support sprocket's view-like file lookup and overriding (and it is an unusual thing to support for JS in the first place).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a JS typo and warns about view-like overriding of files.
At some point in the future it's possible we will use an asset bundler other than sprockets (like webpack or rollup). If we do so we won't be able to support sprocket's view-like file lookup and overriding (and it is an unusual thing to support for JS in the first place).