Remove bourbon from admin #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bourbon provides these shorthands for declaring css positional properties with null. For example: @include margin(null auto); to generate margin-left: auto; margin-right: auto; It's nice enough, but I don't think it's enough of a benefit to justify including bourbon. Users who have used bourbon for custom styles can easily include it in their own application.
gmacdougall
approved these changes
Jan 11, 2018
mamhoff
approved these changes
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bourbon has deprecated most of its features, and removed them in the newly released 5.0.0.
The only remaining feature we're using is the directional property shorthand, which allows declaring css positional properties with null. For example:
to generate
It's nice enough, but I don't think it's enough of a benefit to justify including bourbon.
I've compared the compiled CSS before and after this change and as far as I can tell they are identical.
Users who have used bourbon for their own styles can easily continue including it in their own application.