Fix view for orders api (Fixes Issue #2512)

[skukx]

Refactor _big.json.jbuilder so that it dynamically loads the payment
source view based on that source's payment method.

Add payment views for each payment method which will be used to render a
payment source as json.

Fixes #2512.

[ericsaupe]

👍

[mamhoff]

Would you mind adding a test for this? Also, the partial name for credit cards should be _credit_card.json.jbuilder at this point if I'm not mistaken.

[skukx]

Yeah I can add a test for this. As far as the naming convention, I followed convention on how Spree admin chooses to display payment sources.

See: https://github.com/solidusio/solidus/tree/master/backend/app/views/spree/admin/payments/source_views

If we want to move away from that convention I will change the views mimic that payment source rather than the method

[mamhoff]

Sorry, I thought we changed the partial name with deprecating the Spree::Gateway class, but we didn't:
https://github.com/solidusio/solidus/blob/master/core/app/models/spree/payment_method/credit_card.rb#L15

So, keep the partial name, but do add a spec. ❤️

[skukx]

Let me know if the specs added are sufficient

[mamhoff]

These are sufficient, but should be more explicit. Either render_template('spree/api/payments/source_views/_gateway.html.erb), or test directly for the right thing being rendered as JSON.

[skukx]

Made changes as requested

[kennyadsl]

Thanks!

[skukx]

It is possible that payment.source is a Spree::Payment.
See: https://github.com/solidusio/solidus/blob/v2.4/backend/app/views/spree/admin/payments/show.html.erb#L16

We will need to account for that situation here as well:

json.source do
    ##
    # payment.source could be a Spree::Payment. If it is then we need to call
    # source twice.
    # @see https://github.com/solidusio/solidus/blob/v2.4/backend/app/views/spree/admin/payments/show.html.erb#L16
    #
    payment_source = payment.source.is_a?(Spree::Payment) ? payment.source.source : payment.source
    
    if payment_source
      json.partial!(
        "spree/api/payments/source_views/#{payment.payment_method.partial_name}",
        payment_source: payment_source
      )
    else
      json.nil!
    end
  end

When I get a chance I'll add this to the PR

[houndci-bot]

Some files could not be reviewed due to errors:

.rubocop.yml: Lint/EndAlignment has the wrong namespace - should be Layout

.rubocop.yml: Lint/EndAlignment has the wrong namespace - should be Layout
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)

[skukx]

What is the status of this?

[gmacdougall]

There's a red CircleCI build on this right now. Do you know the source of the errors?

[skukx]

I just pushed something new so it may have to do with that. I'll take a look

[skukx]

Look like I just needed to rebase my branch on master