Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade bootstrap to 4.0.0 #2516

Merged
merged 6 commits into from
Feb 1, 2018
Merged

Upgrade bootstrap to 4.0.0 #2516

merged 6 commits into from
Feb 1, 2018

Conversation

jhawthorn
Copy link
Contributor

@jhawthorn jhawthorn commented Jan 18, 2018 •
edited
Loading

Bootstrap 4 has been released!

Previously we were on 4.0.0-beta.2. There were some breaking changes in beta.3 which we will need to address (not done yet, so consider this WIP) have been fixed :shipit:

From beta 3 migrations:

Input group addons are now specific to their placement relative to an input. We’ve dropped .input-group-addon and .input-group-btn for two new classes, .input-group-prepend and .input-group-append. You must explicitly use an append or a prepend now, simplifying much of our CSS. Within an append or prepend, place your buttons as they would exist anywhere else, but wrap text in .input-group-text.

@jhawthorn jhawthorn added the changelog:solidus_backend Changes to the solidus_backend gem label Jan 18, 2018
gmacdougall
gmacdougall approved these changes Feb 1, 2018
View reviewed changes
Copy link
Member

@gmacdougall gmacdougall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hard work on this.

@jhawthorn jhawthorn merged commit 5961dd9 into solidusio:master Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmacdougall gmacdougall gmacdougall approved these changes

Assignees
No one assigned
Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhawthorn @gmacdougall