-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve master variant documentation #2521
Improve master variant documentation #2521
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny nit.
`Spree::Price`. | ||
- If a product has more than one variant configured, then the master variant | ||
does *not* provide the price and other properties to the line item. **In this | ||
case, the master variant is not saleable**. Instead, it is used as a template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/saleable/sellable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Martin! 👍
a008479
to
99b7474
Compare
variant created for a product. When additional variants are created, they | ||
inherit the properties of the master variant until their unique properties are | ||
set. | ||
Every product has a master variant. By default, the master variant is first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the master variant is first
=> the master variant is *the* first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks. Rebased with this change.
Thanks to gmacdougall for his review.
99b7474
to
be00001
Compare
I rebased some changes to the variants article for my last pull request, but I never ended up pushing those changes to
origin
.These are changes that @gmacdougall requested when he reviewed my PR. They much improve the documentation currently in
master
.My apologies for the mixup. 👍