Replace jquery ui's sortable with Sortable.js #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
tvdeyen
approved these changes
Jan 23, 2018
jhawthorn
force-pushed
the
admin_sortable_final
branch
3 times, most recently
from
61b8460 to
f22c4f3
Compare
This feature doesn't work well. It requires using "Tab" to get focus on an item in the list. After doing that it allows pressing up/down to reorder the list. This feature isn't discoverable to users, so I doubt it has ever been used. It also doesn't exist in any of our other sortable tables in the admin. It could just as be implemented using Sortable.js, which we are moving to from jquery-ui's sortable, but I would not rather not spend the time reimplementing something that doesn't work well and isn't consistent with the rest of the admin. If we want this we need to implement is across all of our sortable lists.
jhawthorn
force-pushed
the
admin_sortable_final
branch
from
f22c4f3 to
411c603
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #2469, we are looking to remove jquery ui from the admin.
I initially tried to use html5sortable which is nice and very minimal (2KB min+gz). However, I was unable to get it to work satisfactorily on the taxon tree page. There were also minor issues sorting tables (it would get confused if the rows were dragged too far #right).
I ended up using Sortable.js, which is a little heavier (6KB min+gz), but we get a lot from that. Everything just worked without additional code from us (which even jquery ui sortable needed to fix some problems). Sortable's behaviour should also be more user friendly: it shown nice "ghost" placeholders to where the element is to be dropped, supports touch events, supports scrolling the page, and even animations (which I didn't enable, but worth trying in the future).
This PR starts with some housekeeping:
backend/admin.jsinto it's own file,backend/components/sortable_table.jstaxons.js.coffee, the "Display order" page, to plain JS (see Clarify that we prefer new files to be in JS, not coffee #2376 for justification)taxonomy.js.coffee, the "taxon tree" page, to plain JSBefore converting the three places jquery-ui/sortable was used:
sortable_table.jsThis is the last piece of the puzzle for #2469 "Replace jQuery UI".