Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation that summarizes Solidus's built-in shipping calculators #2525

Merged

Conversation

benjaminwil
Copy link
Contributor

This pull request extends my previous pull request for calculators documentation (#2511). I recommend that that pull request be reviewed and merged first.

This is part a larger project to improve Solidus's documentation. See this gist with the high-level table of contents. Where and how this documentation will exist is still up for discussion.

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question about sorting calculators differently, thanks!

- [Flat percent](#flat-percent)
- [Flat rate](#flat-rate) (per order)
- [Flexi rate](#flexi-rate)
- [Flat rate per package item](#flat-rate-per-package-item)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about moving Flat rate per package item immediately under Flat rate? Maybe being closer could help readers following their meanings?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Fixed!

@benjaminwil benjaminwil force-pushed the shipping_calculators_documentation branch from 63b753c to 262bb3f Compare March 12, 2018 23:29
@benjaminwil benjaminwil force-pushed the shipping_calculators_documentation branch from 262bb3f to 8447578 Compare March 13, 2018 00:08
@gmacdougall gmacdougall merged commit 16d81d7 into solidusio:master Apr 17, 2018
@benjaminwil benjaminwil deleted the shipping_calculators_documentation branch April 30, 2018 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants