Add a stub article that summarizes Solidus's built-in tax calculator #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmacdougall
requested changes
Mar 8, 2018
guides/calculators/tax-calculator.md
Outdated
| Taxes can apply to line items, shipments, or an entire order. | ||
|
|
||
| The tax calculator uses its calculable – a `Spree::TaxRate` – to calculate tax | ||
| totals. Tax rates are represented as decimal between `0.01` and `1.00`. |
There was a problem hiding this comment.
I don't believe this is true. A tax rate has a precision of 8, scale 5 at the DB level and no such restrictions in rails validations that I know of.
benjaminwil
force-pushed
the
tax_calculator_documentation
branch
from
4a0c097 to
1d01982
Compare
gmacdougall
requested changes
Apr 17, 2018
guides/calculators/tax-calculator.md
Outdated
| Taxes can apply to line items, shipments, or an entire order. | ||
|
|
||
| The tax calculator uses its calculable – a `Spree::TaxRate` – to calculate tax | ||
| totals. Tax rates are represented as decimal between `0` and `1`. |
There was a problem hiding this comment.
The amounts that can be represented here are actually between -999.99999 and 999.99999 to potentially accounting for tax rates over 100% and (for some reason) negative tax rates.
I think it would be best to use a simple example here that a sales tax of 5% should be represented as 0.05 and not 5 as 5 is 500%.
benjaminwil
force-pushed
the
tax_calculator_documentation
branch
from
1d01982 to
e000918
Compare
gmacdougall
approved these changes
Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request extends my previous pull request for calculators documentation (#2511). It depends on #2511 being merged first.
This is part a larger project to improve Solidus's documentation. See this gist with the high-level table of contents. Where and how this documentation will exist is still up for discussion.