Simplify store_credit memo edit JS #2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous store credit JS did a lot more than it needed to, and recreated much of the work that we could get for free from rails-ujs. We were already specifying remote: true, but weren't using that functionality and instead were performing the AJAX explicitly. This commit replaces the existing JS and relies on CSS for display , and jquery-ujs for submitting via AJAX. The user-facing behaviour should be identical. The resulting code has very little to do with store credits, we should consider at a future date looking through our inline edits in the admin and possibly consolidating them.
jhawthorn
force-pushed
the
store_credit_js
branch
from
167df9f to
ad14763
Compare
kennyadsl
approved these changes
Feb 1, 2018
There was a problem hiding this comment.
Thanks, I had some doubts about the usage of 'ajax:success' bound directly on the form (where remote: true is set). My doubts come from this statement on the jQuery .ajaxSuccess documentation page:
As of jQuery 1.9, all the handlers for the jQuery global Ajax events, including those added with the .ajaxSuccess() method, must be attached to document.
I initially thought that this applies to ajax:success as well but than I found this guide.
This seems to be the accepted way in rails land, so 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous store credit coffeescript did a lot more than it needed to, and recreated much of the work that we could get for free from
rails-ujs. We were already specifyingremote: true, but weren't using that functionality and instead were performing the ajax explicitly.This commit replaces the existing JS and relies on CSS for display, and
jquery-ujsfor submitting via AJAX. The user-facing behaviour should be identical.The resulting code has very little to do with store credits, we should consider at a future date looking through our inline edits in the admin and possibly consolidating them.