Add locale chooser to admin #2559
Conversation
jhawthorn
force-pushed
the
locale_chooser
branch
3 times, most recently
from
2800684 to
90836f6
Compare
jhawthorn
force-pushed
the
locale_chooser
branch
2 times, most recently
from
7314080 to
6c6165f
Compare
| @@ -0,0 +1,15 @@ | |||
| <div class="admin-locale-selection"> | |||
There was a problem hiding this comment.
Maybe we should put this div into the if available_locales.size > 1? I think there's no reason to keep the html if empty.
| @@ -5,9 +5,15 @@ | |||
|
|
|||
| RSpec.describe "i18n" do | |||
| before do | |||
| # This reload avoids an issue with I18n.available_locales being cached | |||
There was a problem hiding this comment.
Do you have ideas about why this is needed only in this specs and not in other files that uses I18n?
There was a problem hiding this comment.
I guess the other files don't need a new locale to be autodetected. We should keep an eye out for new failures related to this, though
| <%= | ||
| options_for_select( | ||
| available_locales.map do |locale| | ||
| [I18n.t('spree.i18n.this_file_language', locale: locale, default: locale.to_s, fallback: false), locale] |
There was a problem hiding this comment.
Have you considered using some more explicit string to mark locales available, like active: true?
I know it's not a proper translation but how can a user easily understand that this key is what will make the translation file available?
There was a problem hiding this comment.
I think this is good for now and works with existing locales w/o any further changes.
| <%= | ||
| options_for_select( | ||
| available_locales.map do |locale| | ||
| [I18n.t('spree.i18n.this_file_language', locale: locale, default: locale.to_s, fallback: false), locale] |
There was a problem hiding this comment.
I think this is good for now and works with existing locales w/o any further changes.
This filters I18n.available_locales to return only those with translations for Solidus.
This prevents using locales which have some, but not most i18n translations defined. This fixes an issue when including solidus_auth_devise, but not solidus_i18n. Previously this method would misidentify the few non-en translations in solidus_i18n as forming a valid locale to switch to.
jhawthorn
force-pushed
the
locale_chooser
branch
from
6c6165f to
63721f9
Compare
I want to add a locale selector to the admin.
It's currently too hard to change the locale of the admin. My hope is that by making it easier we will have more users switch to a non-english locale and then through that hopefully get more help keeping them up to date.
I want to implement this in Solidus backend rather than solidus_i18n. This lets us avoid the need for
deface, and makes it more clear that i18n is a concern of Solidus itself.It would be nice if we could recommended that all new users include
solidus_i18n, and listed the gem inside our README's "Getting started" section. To do this we would probably want it to only provide YAML files and there's been some work towards that.Todo
spreenamespace.