Filter unpriced products in taxon_preview #2604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
force-pushed
the
filter_taxon_preview_by_current_pricing_options
branch
from
3294ff9 to
c8d126d
Compare
|
Spec failure unrelated and should be fixed by #2607 |
tvdeyen
approved these changes
Mar 7, 2018
| expect(page).to have_content("Superman T-Shirt", count: 2) | ||
| end | ||
|
|
||
| context "with prices in other currncy" do |
Previously, taxon_preview would return products without prices, resulting in an error. This commit makes it respect the current_pricing_options and filter products which are available in the current price.
jhawthorn
force-pushed
the
filter_taxon_preview_by_current_pricing_options
branch
from
c8d126d to
93a5441
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
taxon_previewwould return products without prices, resulting in an error.This commit makes it respect the
current_pricing_optionsand filter products which are available in the current price.Fixes #2602