Set model_class on admin promotion rules controller #2623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user has the `PromotionManagement` permission set, they are currently unable to add new promotion rules to promotions. This is happening because the promotion rules controller doesn't inherit from the `ResourceController`, so if it doesn't respond to `:model_class`, it will try to authorize using `controller_name.to_sym` instead of the correct class constant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user has the
PromotionManagementpermission set, they are currently unable to add new promotion rules to promotions.This is happening because the promotion rules controller doesn't inherit from the
Spree::Admin::ResourceController, so if it doesn't respond to:model_class, it will try to authorize usingcontroller_name.to_syminstead of the correct class constant.https://github.com/solidusio/solidus/blob/master/backend/app/controllers/spree/admin/base_controller.rb#L21