Set HttpOnly flag when sending guest_token cookie #2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HttpOnly flag prevents XSS attacks by making the cookie inaccessible to JS via the Document.cookie API. It's advisable to also set the Secure flag which only allows cookies to be sent over HTTPS, but that doesn't play nice with development environment so it shouldn't be set by default here. To enable secure cookies you can add the following to your Rails config: `config.force_ssl = true` This will enable secure cookies, HSTS, and TLS redirect, but each can be disabled independently: http://api.rubyonrails.org/v5.1.5/classes/ActionDispatch/SSL.html
jhawthorn
approved these changes
Mar 15, 2018
kennyadsl
approved these changes
Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HttpOnlyflag helps mitigate the damage XSS attacks by making the cookie inaccessible to JS via theDocument.cookieAPI.It's advisable to also set the
Secureflag which only allows cookies to be sent over HTTPS, but that doesn't play nice with development environment so it shouldn't be the default here.To enable secure cookies you can add the following to your Rails config:
config.force_ssl = trueThis will enable secure cookies, HSTS, and TLS redirect, but each can be disabled independently:
http://api.rubyonrails.org/v5.1.5/classes/ActionDispatch/SSL.html