Make partially shipped shipment able to be ready #2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, all inventory units in a shipment needed to be on_hand or cancelled in order for the shipment to be considered shippable. This worked fine for most users, but it caused issues for users who were partially shipping shipments manually using cartons. This commit allows shipments with some shipped inventory units to still be considered "ready".
jhawthorn
force-pushed
the
shipment_ready_state_when_inventory_shipped
branch
from
1db62be to
56997d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all inventory units in a shipment needed to be
on_handorcancelledin order for the shipment to be considered shippable.This worked fine for most users, but it caused issues for users who were partially shipping shipments manually using cartons.
This commit allows shipments with some shipped inventory units to still be considered "ready".
Fixes #2622
Alternative to #2621