Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move EmailValidator under Spree namespace #2635

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Move EmailValidator under Spree namespace #2635

merged 1 commit into from
Mar 16, 2018

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Mar 15, 2018

Change all usages of

validates :email, email: true

to

validates :email, 'spree/email' => true

@tvdeyen
Move EmailValidator under Spree namespace
6d8fd3c 
Change all usages of

    validates :email, email: true

to

    validates :email, 'spree/email' => true
@tvdeyen tvdeyen force-pushed the namespace-email-validator branch from 2127a00 to 6d8fd3c Compare March 15, 2018 22:26
kennyadsl
kennyadsl approved these changes Mar 16, 2018
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, just left a question. Thanks!

core/lib/spree/core/validators/email.rb
end
end
end

# @private
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why @private?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it after reading #2629

jhawthorn
jhawthorn approved these changes Mar 16, 2018
View reviewed changes
Copy link
Contributor

@jhawthorn jhawthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@tvdeyen
Copy link
Member Author

tvdeyen commented Mar 16, 2018

@jhawthorn 😘

@jhawthorn jhawthorn merged commit 05c634c into solidusio:master Mar 16, 2018
@tvdeyen tvdeyen deleted the namespace-email-validator branch March 16, 2018 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@jhawthorn jhawthorn jhawthorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tvdeyen @jhawthorn @kennyadsl