Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean CheckoutsController routes #2649

Merged

Conversation

gevann
Copy link

@gevann gevann commented Mar 26, 2018

The Api::Checkouts::Controller does not have any actions to match the
order_concern routes (empty, cancel, apply_coupon_code).

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@jhawthorn jhawthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would drop all the resources under the order_routes concern, and we can't break compatibility like that

@jhawthorn
Copy link
Contributor

Maybe those missing routes could be moved out of order_concerns and onto resources :orders

The Api::Checkouts::Controller does not have any actions to match the
order_concern routes (empty, cancel, apply_coupon_code).
@gevann gevann force-pushed the remove-unused-api-checkout-routes branch from 70b73ca to 5dc5ec2 Compare March 28, 2018 16:49
@gevann
Copy link
Author

gevann commented Mar 28, 2018

Requested changes have been made, thanks!

Copy link
Contributor

@jhawthorn jhawthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you

@kennyadsl kennyadsl merged commit 0666737 into solidusio:master Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants