Remove promotion_code from adjustment_attributes #2663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
requested changes
Mar 30, 2018
| @@ -133,7 +133,7 @@ def required_fields_for(model) | |||
|
|
|||
| @@adjustment_attributes = [ | |||
| :id, :source_type, :source_id, :adjustable_type, :adjustable_id, | |||
| :amount, :label, :promotion_code, | |||
There was a problem hiding this comment.
There's a promotion_code_id on Spree::Adjustments. Maybe it's better to update that attribute instead of removing it?
gevann
force-pushed
the
correct-adjustment-attributes
branch
from
91147a6 to
60487d5
Compare
Adjustments do not have an attribute called 'promotion_code'. The resulting JSON will always return NULL. This commits changes the adjustment_attributes to instead reference the 'promotion_code_id'.
gevann
force-pushed
the
correct-adjustment-attributes
branch
from
60487d5 to
09a2c17
Compare
|
Requested changes have been made, thanks 😄 |
kennyadsl
approved these changes
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjustments do not have an attribute called 'promotion_code'.