Load email validator from core instead of order #2669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may be desirable to use the email validator from elsewhere before order.rb has been loaded. Additionally, this fixes an issue where EmailValidator would be unloaded in development mode. Spree::Order is autoloaded, and because Spree::EmailValidator is inside the same namespace, this confuses rails into thinking Spree::EmailValidator was defined in this file and can be reloaded. I believe this to be a bug in rails.
tvdeyen
approved these changes
Apr 4, 2018
|
For anyone curious I do think this is a rails bug and spent some time yesterday evening making a test case for it jhawthorn/rails@cf9c10e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be desirable to use the email validator from elsewhere before order.rb has been loaded.
Additionally, this fixes an issue where EmailValidator would be unloaded in development mode. Spree::Order is autoloaded, and because Spree::EmailValidator is inside the same namespace, this confuses rails into thinking Spree::EmailValidator was defined in this file and can be reloaded. I believe this to be a bug in rails.