Move Spree::Taxon#applicable_filters (rebase) #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 3, 2018 16:32
These are only really valid in the frontend, and don't we don't gain anything by it living inside of core. This moves us forward to being able to deprecate Spree::Taxon.applicable_filters
This (untested) method was only used in a frontend call. By pulling it out of here we'll be able to remove the product_filters include (which core doesn't use).
tvdeyen
approved these changes
Apr 4, 2018
done |
DanielePalombo
added a commit
to nebulab/solidus
that referenced
this pull request
Nov 13, 2020
kennyadsl
pushed a commit
to nebulab/solidus
that referenced
this pull request
Nov 17, 2020
kennyadsl
pushed a commit
to nebulab/solidus
that referenced
this pull request
Nov 19, 2020
kennyadsl
pushed a commit
to nebulab/solidus
that referenced
this pull request
Nov 27, 2020
kennyadsl
pushed a commit
to nebulab/solidus
that referenced
this pull request
Nov 27, 2020
kennyadsl
pushed a commit
to nebulab/solidus
that referenced
this pull request
Dec 9, 2020
kennyadsl
pushed a commit
to nebulab/solidus
that referenced
this pull request
Dec 10, 2020
DanielePalombo
added a commit
to nebulab/solidus
that referenced
this pull request
Dec 11, 2020
kennyadsl
pushed a commit
to nebulab/solidus
that referenced
this pull request
Dec 15, 2020
DanielePalombo
added a commit
to nebulab/solidus
that referenced
this pull request
Dec 18, 2020
kennyadsl
pushed a commit
to nebulab/solidus
that referenced
this pull request
Dec 21, 2020
kennyadsl
pushed a commit
to nebulab/solidus
that referenced
this pull request
Jan 19, 2021
kennyadsl
pushed a commit
to nebulab/solidus
that referenced
this pull request
Jan 28, 2021
kennyadsl
pushed a commit
to nebulab/solidus
that referenced
this pull request
Jan 28, 2021
rmparr
pushed a commit
to rmparr/solidus
that referenced
this pull request
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased since it conflicted after #2408 was merged
Fixes #2409