Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a guides index and generator #2671

Merged
merged 2 commits into from
Apr 5, 2018
Merged

Add a guides index and generator #2671

merged 2 commits into from
Apr 5, 2018

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Apr 4, 2018

Run the generator with

./list.rb > index.md

houndci-bot
houndci-bot reviewed Apr 4, 2018
View reviewed changes
guides/list.rb
@@ -0,0 +1,43 @@
#!/usr/bin/env ruby
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint/ScriptPermission: Script file list.rb doesn't have execute permission.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to, but git doesn't let me to.

tvdeyen added 2 commits April 4, 2018 11:32
@tvdeyen
Add a guides index generator
ce18658 
Run generator with

    ./list.rb > index.md
@tvdeyen
Generate guides index file
ac0c23c
@benjaminwil
Copy link
Contributor

Nice! Thanks for this 👏

@jhawthorn jhawthorn merged commit 35f2408 into solidusio:master Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tvdeyen @benjaminwil @kennyadsl @houndci-bot @jhawthorn