UI fixes for admin locale select #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the admin locale select is displayed alone (ie. on the login screen) it has no bottom margin. By keeping the bottom margin and convert the admin user menu from paddings to margins we take advantage of collapsing margins. Both displayed alone have their full margin and when displayed together the margin collapses.
The store available locales select is a multi select. This is where select2 is still beneficial.
4 tasks
jhawthorn
reviewed
Apr 6, 2018
| @@ -1,7 +1,7 @@ | |||
| <% available_locales = Spree.i18n_available_locales %> | |||
| <% available_locales = current_store.available_locales %> | |||
There was a problem hiding this comment.
I think the current_store.available_locales should apply to the frontend only
There was a problem hiding this comment.
Ideally we would have two configurations, but this seems overkill to me. We could keep it as is, if we encourage the users of solidus_i18n to copy over only the files they need in their app (what I recommend anyway).
|
We should be more descriptive then
|
We have lots of fields on the store administration form. Let's use the plenty space we have to disaply them nicely. Also converts the meta description field into textarea and use a custom Bootstrap select for the default currency.
To be very clear about what this actually does we add a field hint to the store admin form.
tvdeyen
force-pushed
the
admin-locale-selection-fixes
branch
from
f1003a0 to
d512e53
Compare
jhawthorn
approved these changes
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have a admin local select and store owners can configure available locales for their stores we should improve the UI/UX a little bit.
Admins should only be able to choose from configured available locales instead of all locales in the systemThe store administration form uses two columns to display all the fields.
The locale select uses select2, because it is a multi select and this is where select2 still shines.
When the local select is displayed alone, as on the login screen, it has correct margins.
Screenshot